Skip to content

Conversation

@Vagabond
Copy link
Contributor

@Vagabond Vagabond commented Sep 4, 2012

Worker arguments are passed as a separate list, now.

@travisbot
Copy link

This pull request passes (merged d1f59b5 into 6b03b51).

@rzezeski
Copy link
Contributor

Doing a fly-by pass on this PR...is this still relevant?

@Vagabond
Copy link
Contributor Author

This is absolutely something we need to do, except it may be even more involved now, because of all the changes upstream.

@slfritchie
Copy link
Contributor

@Vagabond Time for some belated repo curating ... is there any plan to fix this for Riak 2.0?

@slfritchie
Copy link
Contributor

I know you're busy, Andrew, but ... re-ping?

@rzezeski
Copy link
Contributor

Setting milestone to 2.1 since it's something we absolutely need to do but too late for 2.0.

@jrwest
Copy link
Contributor

jrwest commented Mar 24, 2014

leaving at milestone 2.1

@JeetKunDoug
Copy link
Contributor

@seancribbs is this change still necessary? If so, what do we do about our branch of poolboy? Update ours to latest?

@Vagabond
Copy link
Contributor Author

Run the quickcheck tests again, make sure things are still good and update, yeah.

IIRC, some of the poolboy changes caused a minor problem with the EQC tests around worker exits, but I think it was a cosmetic problem, not a property violation. Make sure you run a lot of iterations of the tests.

@JeetKunDoug
Copy link
Contributor

FYI - this PR is superseded by #639.

@seancribbs seancribbs closed this Nov 3, 2014
@seancribbs seancribbs deleted the adt-poolboy-api branch April 1, 2015 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants